feat: 1346 license details UI #1519

Alessandro100 · 2025-12-10T14:29:04Z

Summary:

Feed Summary

Adds License as own group
Displays License ID -> Dialog displaying details
API call to get license (store) -> caches for 1 hour
Removed "See License" button at the top
Refactored GBFS Feed Info component to use new design
GtfsFeedSummary -> renamed -> FeedSummary
Updated Theme colors for warning and info to be more accessibility compatible
Included translations

Expected behavior:

When going on a feed that has a license id, you'll be able to see it in the feed summary area. If you click it, a dialog should appear showing the rules

If the feed only has a license url (no license id) it will display a link you can click on

If the feed does not have a license url, the license group will not show up

The GBFS feed info page has been updated

Testing tips:

Go through random feeds and see if the license + license info displays correctly. Pay special attention to the wording (translations) and the GBFS page due to it's update

Please make sure these boxes are checked before submitting your pull request - thanks!

Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
Add or update any needed documentation to the repo
Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
Linked all relevant issues
Include screenshot(s) showing how this pull request works and fixes the issue(s)

Copilot

Pull request overview

This PR implements a comprehensive redesign of the license details UI and feed summary components. The changes introduce a new dialog-based license viewer that displays structured license rules (permissions, conditions, limitations) and consolidates the GBFS and GTFS feed information displays into a single unified component.

Key Changes:

Added a new license Redux store with saga for fetching and caching license details
Created a LicenseDialog component that displays license rules categorized by type with color-coded visual indicators
Consolidated GbfsFeedInfo and GtfsFeedSummary into a single FeedSummary component that handles all feed types
Updated theme colors for warning and info to improve accessibility
Removed redundant "See License" button from feed header

Reviewed changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
`web-app/src/app/types.ts`	Adds license profile action types and error handling types
`web-app/src/app/store/saga/root-saga.ts`	Registers the new license saga watcher
`web-app/src/app/store/saga/license-saga.ts`	Implements license fetching with 1-hour caching logic
`web-app/src/app/store/reducers.ts`	Integrates license reducer into root state
`web-app/src/app/store/license-selectors.ts`	Provides selector functions for license state access
`web-app/src/app/store/license-reducer.ts`	Manages license loading state and cached data
`web-app/src/app/services/feeds/index.ts`	Adds API endpoint for fetching license details
`web-app/src/app/screens/Feed/index.tsx`	Removes license button, switches to unified FeedSummary component
`web-app/src/app/screens/Feed/components/LicenseDialog.tsx`	New dialog displaying license rules with categorized sections
`web-app/src/app/screens/Feed/components/GbfsFeedInfo.tsx`	Deleted (functionality moved to FeedSummary)
`web-app/src/app/screens/Feed/components/FeedSummary.tsx`	Unified component supporting GTFS, GTFS-RT, and GBFS feeds with license integration
`web-app/src/app/screens/Feed/components/FeedAuthenticationSummaryInfo.tsx`	Deleted (functionality consolidated into FeedSummary)
`web-app/src/app/screens/Feed/components/CopyLinkElement.tsx`	Adds 'internal' link type support for triggering dialog actions
`web-app/src/app/components/CoveredAreaMap.tsx`	Removes conditional GBFS border styling
`web-app/src/app/Theme.ts`	Updates warning and info colors for better accessibility
`web-app/public/locales/en/feeds.json`	Adds translations for license dialog and feed summary labels
`web-app/public/locales/en/common.json`	Adds common translations for UI elements

web-app/src/app/screens/Feed/components/CopyLinkElement.tsx

web-app/src/app/screens/Feed/components/FeedSummary.tsx

web-app/src/app/store/saga/license-saga.ts

Copilot · 2025-12-10T14:31:04Z

web-app/src/app/screens/Feed/components/LicenseDialog.tsx

+                    {t('license.contributeMessage')}
+                  </Typography>
+                  <Link
+                    href={`https://github.com/MobilityData/licenses-aas/blob/main/data/licenses/${license.id}.json`}


The GitHub repository URL is hardcoded. Consider moving this to a configuration constant or environment variable to make it easier to maintain if the repository location changes.

web-app/src/app/screens/Feed/components/FeedSummary.tsx

github-actions · 2025-12-10T14:40:55Z

*Lighthouse ran on https://mobility-feeds-dev--pr-1519-q76db6ib.web.app/ * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟠 69	🟢 100	🟢 100	🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1519-q76db6ib.web.app/feeds * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟠 64	🟢 91	🟢 100	🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1519-q76db6ib.web.app/feeds/gtfs/mdb-2126 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟠 70	🔴 0	🟢 93	🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1519-q76db6ib.web.app/feeds/gtfs_rt/mdb-2585 * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟢 90	🟠 87	🟢 100	🟢 100

*Lighthouse ran on https://mobility-feeds-dev--pr-1519-q76db6ib.web.app/gbfs/gbfs-flamingo_porirua * (Desktop)
⚡️ HTML Report Lighthouse report for the changes in this PR:

Performance	Accessibility	Best Practices	SEO
🟢 99	🟢 100	🟢 100	🟢 100

github-actions · 2025-12-10T14:41:05Z

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-1519-q76db6ib.web.app

…or improved rule presentation and responsiveness

…, and update FeedSummary component to use them.

… and standardize null/undefined checks in FeedSummary.

emmambd · 2025-12-10T16:31:01Z

@Alessandro100 This is great! Is there a good example for GTFS as well? I'm having trouble finding an example feed.

My only thought for improvement is that the SPDX breakdown is so clear and visually beautiful that I don't want people to miss it. Only presenting it after clicking on the license type feels too easy to miss to me.

Thoughts on adding a button that says "License Detail Summary" or a visual element that's similar? This is so useful I don't want anyone to miss it.

davidgamez · 2025-12-10T16:39:55Z

@Alessandro100 This is great! Is there a good example for GTFS as well? I'm having trouble finding an example feed.

My only thought for improvement is that the SPDX breakdown is so clear and visually beautiful that I don't want people to miss it. Only presenting it after clicking on the license type feels too easy to miss to me.

Thoughts on adding a button that says "License Detail Summary" or a visual element that's similar? This is so useful I don't want anyone to miss it.

Few examples:

emmambd · 2025-12-10T16:42:19Z

Thanks @davidgamez! I should have thought to look at the French data to check. No new comments from me — only the one above, where I want to make sure this amazing feature gets the attention it deserves!

Alessandro100 · 2025-12-10T18:37:17Z

Updated version, thoughts?

emmambd · 2025-12-10T18:39:18Z

@Alessandro100 Perfect. All good on my end. I won't approve the PR so code review can still continue.

davidgamez · 2025-12-10T18:51:24Z

web-app/src/app/store/saga/license-saga.ts

+      string,
+      { license: License; fetchedAt: number }
+    >;
+    // License data rarely changes, but we use a 1-hour cache duration to ensure


davidgamez

LGTM! 🎖️

Alessandro100 requested a review from Copilot December 10, 2025 14:29

Alessandro100 self-assigned this Dec 10, 2025

Copilot AI reviewed Dec 10, 2025

View reviewed changes

Alessandro100 added 9 commits December 10, 2025 10:08

license store setup

8b59ee5

License detail UI

5c25f3c

GBFS Feed Info UI consolidation

8be149c

updated info and warning colors for accessibility color contrast

6eafeb9

enhance license display in feed summary and refactor license dialog f…

5f8acb6

…or improved rule presentation and responsiveness

lint fixes

fc6b2d4

feat: add i18n keys for feed summary, license details, and validators…

0c90151

…, and update FeedSummary component to use them.

gbfs wording

fce8bda

refactor: Refine license saga types, improve internal link rendering,…

9d018ca

… and standardize null/undefined checks in FeedSummary.

Alessandro100 force-pushed the feat/1346-license-details-ui branch from 296ebcd to 9d018ca Compare December 10, 2025 15:08

davidgamez reviewed Dec 10, 2025

View reviewed changes

davidgamez approved these changes Dec 10, 2025

View reviewed changes

update license styling

84833be

Alessandro100 merged commit e38e7b1 into main Dec 10, 2025
4 checks passed

Alessandro100 deleted the feat/1346-license-details-ui branch December 10, 2025 19:11

feat: 1346 license details UI #1519

feat: 1346 license details UI #1519

Uh oh!

Conversation

Alessandro100 commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 10, 2025

Uh oh!

emmambd commented Dec 10, 2025

Uh oh!

davidgamez commented Dec 10, 2025

Uh oh!

emmambd commented Dec 10, 2025

Uh oh!

Alessandro100 commented Dec 10, 2025

Uh oh!

emmambd commented Dec 10, 2025

Uh oh!

davidgamez Dec 10, 2025

Choose a reason for hiding this comment

Uh oh!

davidgamez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Alessandro100 commented Dec 10, 2025 •

edited

Loading

github-actions bot commented Dec 10, 2025 •

edited

Loading